[PATCH] [issue806] final fix
remove 'umount -a',see http://bts.grml.org/grml/issue806 --- grml-debootstrap | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/grml-debootstrap b/grml-debootstrap index dc4006d..f9b5ebb 100755 --- a/grml-debootstrap +++ b/grml-debootstrap @@ -644,7 +644,7 @@ bailout(){ [ -x "$MNTPOINT"/etc/init.d/ssh ] && "$MNTPOINT"/etc/init.d/ssh stop [ -x "$MNTPOINT"/etc/init.d/mdadm ] && "$MNTPOINT"/etc/init.d/mdadm stop # ugly, but make sure we really don't leave anything (/proc /proc is intended) - for ARG in /sys -a /proc /proc ; do + for ARG in /sys /proc /proc ; do [ -x "$MNTPOINT"/bin/umount ] && chroot "$MNTPOINT" umount $ARG >/dev/null 2>&1 || true done umount "$MNTPOINT"/dev >/dev/null 2>&1 || true
* Tong Sun suntong@cpan.org [Tue Jun 08, 2010 at 05:50:52PM -0400]:
remove 'umount -a',see http://bts.grml.org/grml/issue806
grml-debootstrap | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/grml-debootstrap b/grml-debootstrap index dc4006d..f9b5ebb 100755 --- a/grml-debootstrap +++ b/grml-debootstrap @@ -644,7 +644,7 @@ bailout(){ [ -x "$MNTPOINT"/etc/init.d/ssh ] && "$MNTPOINT"/etc/init.d/ssh stop [ -x "$MNTPOINT"/etc/init.d/mdadm ] && "$MNTPOINT"/etc/init.d/mdadm stop # ugly, but make sure we really don't leave anything (/proc /proc is intended)
for ARG in /sys -a /proc /proc ; do
for ARG in /sys /proc /proc ; do [ -x "$MNTPOINT"/bin/umount ] && chroot "$MNTPOINT" umount $ARG >/dev/null 2>&1 || true done umount "$MNTPOINT"/dev >/dev/null 2>&1 || true
Good catch, thanks!
Applied with slightly adjusted commit message and pushed:
http://git.grml.org/?p=grml-debootstrap.git;a=commit;h=2c66520
regards, -mika-
Teilnehmer (2)
-
Michael Prokop -
Tong Sun