[Git-commits] [grml/grml-debootstrap] 0208c8: Verify that GRUB configuration points to valid blo...

[Michael Prokop]

  Branch: refs/heads/master
  Home:   https://github.com/grml/grml-debootstrap
  Commit: 0208c8af237b7bb5cd2f89c1cccd091f92ecd651
      https://github.com/grml/grml-debootstrap/commit/0208c8af237b7bb5cd2f89c1cccd091f92ecd651
  Author: Michael Prokop <mika at grml.org>
  Date:   2025-05-09 (Fri, 09 May 2025)

  Changed paths:
    M grml-debootstrap

  Log Message:
  -----------
  Verify that GRUB configuration points to valid block device

When invoking grml-debootstrap with `--grub /dev/`, it fails with:

| Installing for i386-pc platform.
| grub-install: error: cannot read `/dev': Is a directory.
| Error: failed to execute 'grub-install --no-floppy --target=i386-pc /dev/'.

This is caused by our own invocation of `grub-install --no-floppy
--target=i386-pc "${device}`, while we're also setting GRUB's debconf to
`grub-cloud-amd64/install_devices: /dev/`.

Furthermore, when invoking grml-debootstrap with `--grub /dev/fail`,
it fails hard - but non-obvious - within invocation of efibootmgr:

| Invoking efibootmgr
| BootCurrent: 0003
| Timeout: 1 seconds
| [...]
| MirrorStatus: Platform does not support address range mirror
| DesiredMirroredPercentageAbove4G: 0.00
| DesiredMirrorMemoryBelow4GB: false
| Unexpected non-zero exit code 1 in /bin/chroot-script /bin/chroot-script /bin/chroot-script at line 725 853 0 detected!

Avoid any such misusage, by validating that the GRUB device
at least points to a valid block device.

See https://github.com/grml/grml-debootstrap/issues/339


  Commit: 904c6bb16524dcc54592d66aa55ede125fdf6544
      https://github.com/grml/grml-debootstrap/commit/904c6bb16524dcc54592d66aa55ede125fdf6544
  Author: Michael Prokop <115592+mika at users.noreply.github.com>
  Date:   2025-05-09 (Fri, 09 May 2025)

  Changed paths:
    M grml-debootstrap

  Log Message:
  -----------
  Merge pull request #340 from grml/mika/valid-grub-target

Verify that GRUB configuration points to valid block device


Compare: https://github.com/grml/grml-debootstrap/compare/a95a7dd286fe...904c6bb16524

To unsubscribe from these emails, change your notification settings at https://github.com/grml/grml-debootstrap/settings/notifications