[Git-commits] [grml/grml-live] 65061f: save-config: initialize DEBUG variable

[Chris Hofstaedtler]

  Branch: refs/heads/zeha/bash
  Home:   https://github.com/grml/grml-live
  Commit: 65061fbdce8ee767cee0a0fb5c959213042a13ce
      https://github.com/grml/grml-live/commit/65061fbdce8ee767cee0a0fb5c959213042a13ce
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M config/files/GRMLBASE/usr/bin/save-config

  Log Message:
  -----------
  save-config: initialize DEBUG variable

Fix "integer expression expected" error by initializing DEBUG=0
at the start of the script. The debug function expects DEBUG to be
a number for the -gt comparison, but it was never set.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply at anthropic.com>


  Commit: 2dd1a960681f376089fa240f86a473f4e8560289
      https://github.com/grml/grml-live/commit/2dd1a960681f376089fa240f86a473f4e8560289
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M config/files/GRMLBASE/etc/grml/autoconfig
    M config/files/GRMLBASE/etc/grml/autoconfig.local
    M config/files/GRMLBASE/usr/bin/restore-config
    M config/files/GRMLBASE/usr/bin/save-config
    M config/files/GRMLBASE/usr/share/grml-autoconfig/autoconfig.functions
    M config/files/GRMLBASE/usr/share/grml-autoconfig/grml-autoconfig

  Log Message:
  -----------
  config: fix shellcheck issues across all autoconfig scripts

Fix numerous shellcheck warnings and errors in the grml-autoconfig system:

Core fixes:
- Replace signal numbers with names (INT TERM SEGV)
- Fix deprecated egrep usage (use grep -E)
- Add proper quoting for variables and paths
- Separate variable declaration from assignment
- Fix cd commands with error handling (|| exit/continue)
- Replace legacy backticks with $(...) command substitution
- Fix parameter expansion quoting patterns
- Replace fragile for loops over find with while read

Script-specific improvements:
- save-config: Fix command substitution and error handling in subshells
- autoconfig.functions: Add shellcheck disable for intentionally unused variables
- All scripts: Add shellcheck source directives for proper analysis
- Preserve $EXTRACTOPTIONS word splitting behavior where needed

Maintains all functionality while improving shell script best practices
and enabling comprehensive static analysis coverage.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply at anthropic.com>


  Commit: c74fbd4edc90b59891fe5e1e4528dfac894e5f5b
      https://github.com/grml/grml-live/commit/c74fbd4edc90b59891fe5e1e4528dfac894e5f5b
  Author: Chris Hofstaedtler <chris.hofstaedtler at deduktiva.com>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M config/files/GRMLBASE/usr/share/grml-autoconfig/autoconfig.functions

  Log Message:
  -----------
  autoconfig.functions: drop start of obsolete haveged, rmnologin services


  Commit: f785bd6fadb901edae3cf96f89bb9107f1bea50a
      https://github.com/grml/grml-live/commit/f785bd6fadb901edae3cf96f89bb9107f1bea50a
  Author: Chris Hofstaedtler <chris.hofstaedtler at deduktiva.com>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M config/files/GRMLBASE/usr/share/grml-autoconfig/autoconfig.functions

  Log Message:
  -----------
  autoconfig.functions: remove unreachable startx code block


  Commit: a2c75fb813254abf8774d4ef7ade9911efd129db
      https://github.com/grml/grml-live/commit/a2c75fb813254abf8774d4ef7ade9911efd129db
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M config/files/GRMLBASE/usr/share/grml-autoconfig/autoconfig.functions

  Log Message:
  -----------
  autoconfig.functions: appease shellcheck

And probably fix testcd.


  Commit: ce9846cf84cb6e0da3e77f8b6b7233787998a5c6
      https://github.com/grml/grml-live/commit/ce9846cf84cb6e0da3e77f8b6b7233787998a5c6
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M config/files/GRMLBASE/lib/brltty/brltty.sh

  Log Message:
  -----------
  brltty.sh: appease shellcheck


  Commit: 9f3643fd452bf0323208a57ede1f4480a5611678
      https://github.com/grml/grml-live/commit/9f3643fd452bf0323208a57ede1f4480a5611678
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M .github/workflows/pr-review.yml
    M debian/update-grml-live-version

  Log Message:
  -----------
  workflows: simplify shellcheck with directory-based execution

Replace reviewdog with direct shellcheck execution to improve reliability:

- Remove reviewdog dependency (not working reliably for PR comments)
- Run shellcheck from each file's directory to resolve relative paths
- Expand coverage to all shell scripts in the repository
- Fix shellcheck warning in debian/update-grml-live-version
- Combine main and test script checking into single job
- Ensure shellcheck source directives work correctly

This provides reliable shellcheck execution with clear console output
and proper path resolution for all files.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply at anthropic.com>


Compare: https://github.com/grml/grml-live/compare/74c5d35abb86...9f3643fd452b

To unsubscribe from these emails, change your notification settings at https://github.com/grml/grml-live/settings/notifications