[Git-commits] [grml/grml-live] 91ea1d: workflows: simplify shellcheck with directory-base...

[Chris Hofstaedtler]

  Branch: refs/heads/zeha/bash
  Home:   https://github.com/grml/grml-live
  Commit: 91ea1dba1102cd5dfc23bed539876a563766ff19
      https://github.com/grml/grml-live/commit/91ea1dba1102cd5dfc23bed539876a563766ff19
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M .github/workflows/pr-review.yml
    M debian/update-grml-live-version

  Log Message:
  -----------
  workflows: simplify shellcheck with directory-based execution

Replace reviewdog with direct shellcheck execution to improve reliability:

- Remove reviewdog dependency (not working reliably for PR comments)
- Run shellcheck from each file's directory to resolve relative paths
- Expand coverage to all shell scripts in the repository
- Fix shellcheck warning in debian/update-grml-live-version
- Combine main and test script checking into single job
- Ensure shellcheck source directives work correctly

This provides reliable shellcheck execution with clear console output
and proper path resolution for all files.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply at anthropic.com>


  Commit: 70401d0cb7534a4de3be8b53d9be4c4ce9addf2d
      https://github.com/grml/grml-live/commit/70401d0cb7534a4de3be8b53d9be4c4ce9addf2d
  Author: Chris Hofstaedtler <ch at grml.org>
  Date:   2025-06-20 (Fri, 20 Jun 2025)

  Changed paths:
    M config/files/GRMLBASE/etc/grml/autoconfig
    M config/files/GRMLBASE/etc/grml/autoconfig.local
    M config/files/GRMLBASE/usr/bin/restore-config
    M config/files/GRMLBASE/usr/bin/save-config
    M config/files/GRMLBASE/usr/share/grml-autoconfig/autoconfig.functions
    M config/files/GRMLBASE/usr/share/grml-autoconfig/grml-autoconfig

  Log Message:
  -----------
  config: fix shellcheck issues across all autoconfig scripts

Fix numerous shellcheck warnings and errors in the grml-autoconfig system:

Core fixes:
- Replace signal numbers with names (INT TERM SEGV)
- Fix deprecated egrep usage (use grep -E)
- Add proper quoting for variables and paths
- Separate variable declaration from assignment
- Fix cd commands with error handling (|| exit/continue)
- Replace legacy backticks with $(...) command substitution
- Fix parameter expansion quoting patterns
- Replace fragile for loops over find with while read

Script-specific improvements:
- save-config: Fix command substitution and error handling in subshells
- autoconfig.functions: Add shellcheck disable for intentionally unused variables
- All scripts: Add shellcheck source directives for proper analysis
- Preserve $EXTRACTOPTIONS word splitting behavior where needed

Maintains all functionality while improving shell script best practices
and enabling comprehensive static analysis coverage.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply at anthropic.com>


Compare: https://github.com/grml/grml-live/compare/6f0a7c2c4abc...70401d0cb753

To unsubscribe from these emails, change your notification settings at https://github.com/grml/grml-live/settings/notifications