[Git-commits] [grml/grml-live] fb297b: shellcheck: expand coverage to include all shell s...
Chris Hofstaedtler
noreply at github.com
Fri Jun 20 21:21:16 CEST 2025
Branch: refs/heads/zeha/bash
Home: https://github.com/grml/grml-live
Commit: fb297b13af001ebb47d26d9a6636ce659f6d515e
https://github.com/grml/grml-live/commit/fb297b13af001ebb47d26d9a6636ce659f6d515e
Author: Chris Hofstaedtler <ch at grml.org>
Date: 2025-06-20 (Fri, 20 Jun 2025)
Changed paths:
M .github/workflows/pr-review.yml
M debian/update-grml-live-version
Log Message:
-----------
shellcheck: expand coverage to include all shell scripts
Extend shellcheck workflow to cover all shell scripts in the repository:
- Migration and build scripts (migrate-to-minifai, build-driver/build)
- Config file scripts (binaries, system scripts, udev scripts)
- Test scripts in test/ directory
Fixed shellcheck warning in debian/update-grml-live-version by properly quoting
the $version variable in sed command.
This provides comprehensive static analysis coverage while excluding
zsh-only scripts which shellcheck cannot process.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply at anthropic.com>
Commit: 67ca74c89c9cc3d46e0486a2a9164aff1b7b747f
https://github.com/grml/grml-live/commit/67ca74c89c9cc3d46e0486a2a9164aff1b7b747f
Author: Chris Hofstaedtler <ch at grml.org>
Date: 2025-06-20 (Fri, 20 Jun 2025)
Changed paths:
M config/files/GRMLBASE/usr/bin/restore-config
M config/files/GRMLBASE/usr/bin/save-config
M config/files/GRMLBASE/usr/share/grml-autoconfig/autoconfig.functions
M config/files/GRMLBASE/usr/share/grml-autoconfig/grml-autoconfig
Log Message:
-----------
config: convert grml-autoconfig system from zsh to bash
Convert the entire grml-autoconfig system (restore-config, save-config,
autoconfig.functions, and grml-autoconfig) from zsh to bash for better
portability and shellcheck compatibility.
Key conversion changes:
- Replace zsh-specific syntax with bash equivalents:
* [[ pattern == *match* ]] → case statements
* zparseopts → manual argument parsing
* ${=variable} word splitting → standard bash
* |& redirection → 2>&1 | for compatibility
* pipestatus[1] → PIPESTATUS[0]
- Remove zsh dependencies:
* Remove iszsh() function and setopt calls
* Replace zsh math functions with bash arithmetic
* Simplify signal trapping with proper signal names
- Fix color system integration:
* Use $GREEN/$BLUE/$NORMAL from grml_colors
* Maintain original color scheme in usage messages
* Preserve grml visual identity
- Add shellcheck source directives:
* Help shellcheck understand file relationships
* Enable static analysis of sourced files
All scripts maintain full backward compatibility while gaining shellcheck
coverage and improved portability across shell implementations.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply at anthropic.com>
Compare: https://github.com/grml/grml-live/compare/2207c42d7f13...67ca74c89c9c
To unsubscribe from these emails, change your notification settings at https://github.com/grml/grml-live/settings/notifications
More information about the Git-commits
mailing list